Fix #814: raise clear error for empty Hazard in ImpactCalc.impact#1290
Open
ankurmahiwal118028 wants to merge 1 commit into
Open
Fix #814: raise clear error for empty Hazard in ImpactCalc.impact#1290ankurmahiwal118028 wants to merge 1 commit into
ankurmahiwal118028 wants to merge 1 commit into
Conversation
Computing impact with a Hazard containing zero events previously crashed deep inside ``np.array_split`` with the obscure message "number sections must be larger than 0". This adds an early guard in ``ImpactCalc.impact`` that raises a ``ValueError`` with a clear explanation when ``self.hazard.size == 0``. Closes CLIMADA-project#814
ankurmahiwal118028
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #814. Adds an early guard in ImpactCalc.impact that raises a ValueError when the Hazard has no events, replacing the obscure np.array_split crash. Regression test added in test_impact_calc.py. CHANGELOG updated.